Skip to content

Fix paddle.vision.ops.deform_conv2d API big Tensor#74058

Merged
wanghuancoder merged 9 commits intoPaddlePaddle:developfrom
xingmingyyj:fix_deform_con2d_api
Jul 24, 2025
Merged

Fix paddle.vision.ops.deform_conv2d API big Tensor#74058
wanghuancoder merged 9 commits intoPaddlePaddle:developfrom
xingmingyyj:fix_deform_con2d_api

Conversation

@xingmingyyj
Copy link
Contributor

@xingmingyyj xingmingyyj commented Jul 15, 2025 •
edited
Loading

PR Category

Operator Mechanism

PR Types

Bug fixes

Description

  1. 修复int溢出导致的访存越界问题
  2. 修复 CUDA error(9)问题
  3. batch较大时存在精度diff
paddle.vision.ops.deform_conv2d(Tensor([5070448, 3, 5, 5],"float32"), Tensor([5070448, 18, 5, 5],"float32"), Tensor([6, 3, 3, 3],"float32"), None, list[1,1,], list[1,1,], list[1,1,], 1, 1, Tensor([5070448, 9, 5, 5],"float32"), )
Not equal to tolerance rtol=0.01, atol=0.01
Tensor-likes are not close!

Mismatched elements: 3 / 2281701600 (0.0%)
Greatest absolute difference: 0.04030437394976616 at index (1852051, 0, 0, 2) (up to 0.01 allowed)
Greatest relative difference: 1.0 at index (910808, 0, 0, 3) (up to 0.01 allowed)
ACTUAL: (shape=torch.Size([5070448, 18, 5, 5]), dtype=torch.float32)
tensor([[[[ 0.0000e+00,  0.0000e+00, -3.4506e-02, -8.3038e-04,  0.0000e+00],
          [-8.7802e-04,  3.7523e-03,  1.5622e-02, -8.7787e-04,  5.6141e-03],

offset的反向传播公式为：
$$\frac{\partial L}{\partial \Delta p_n} = \sum_{p_0} \frac{\partial L}{\partial y(p_0)} \cdot w(p_n) \cdot \frac{\partial x (p_0 + p_n + \Delta p_n)}{\partial \Delta p_n}$$
其中：

  1. 排除上述问题后，image_shape较大时仍然存在精度diff
test begin: paddle.vision.ops.deform_conv2d(x=Tensor([4, 22817014, 5, 5],"float32"), offset=Tensor([4, 18, 3, 3],"float32"), weight=Tensor([5, 22817014, 3, 3],"float32"), bias=None, stride=list[1,1,], padding=list[0,0,], dilation=list[1,1,], deformable_groups=1, groups=1, mask=Tensor([4, 9, 3, 3],"float32"), )
[accuracy error] backward  paddle.vision.ops.deform_conv2d(x=Tensor([4, 22817014, 5, 5],"float32"), offset=Tensor([4, 18, 3, 3],"float32"), weight=Tensor([5, 22817014, 3, 3],"float32"), bias=None, stride=list[1,1,], padding=list[0,0,], dilation=list[1,1,], deformable_groups=1, groups=1, mask=Tensor([4, 9, 3, 3],"float32"), ) 
 Not equal to tolerance rtol=0.01, atol=0.01
Tensor-likes are not close!

Mismatched elements: 1833583996 / 2281701400 (80.4%)
Greatest absolute difference: 1.451427698135376 at index (3, 22517627, 2, 1) (up to 0.01 allowed)
Greatest relative difference: inf at index (1, 13256072, 1, 4) (up to 0.01 allowed)
ACTUAL: (shape=torch.Size([4, 22817014, 5, 5]), dtype=torch.float32)
tensor([[[[-1.1867e-02, -9.4617e-02, -6.7302e-02,  4.5707e-02,  1.0042e-01],
          [-1.4820e-03,  5.5286e-03,  2.1573e-02, -7.3028e-03,  7.3889e-02],

怀疑是Matmul导致，Matmul修复后进行验证。
Pcard-73263

@paddle-bot
Copy link

paddle-bot bot commented Jul 15, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 26.15385% with 48 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@b8b4c24). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...dle/phi/kernels/cpu/deformable_conv_grad_kernel.cc 0.00% 45 Missing ⚠️
...hi/kernels/impl/deformable_conv_grad_kernel_impl.h 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (26.15%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #74058   +/-   ##
==========================================
  Coverage           ?   26.15%           
==========================================
  Files              ?        3           
  Lines              ?       65           
  Branches           ?        0           
==========================================
  Hits               ?       17           
  Misses             ?       48           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lshpku
lshpku previously approved these changes Jul 23, 2025
View reviewed changes
wanghuancoder
wanghuancoder previously approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingmingyyj xingmingyyj dismissed stale reviews from wanghuancoder and lshpku via 52aff66 July 23, 2025 13:02
wanghuancoder
wanghuancoder approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder wanghuancoder merged commit 3067726 into PaddlePaddle:develop Jul 24, 2025
104 of 109 checks passed
@xingmingyyj xingmingyyj deleted the fix_deform_con2d_api branch July 24, 2025 08:47
xingmingyyj added a commit to xingmingyyj/Paddle that referenced this pull request Jul 30, 2025
@xingmingyyj
Revert "Fix paddle.vision.ops.deform_conv2d API big Tensor (PaddlePad…
216f550 
…dle#74058)"

This reverts commit 3067726.
@xingmingyyj xingmingyyj mentioned this pull request Jul 30, 2025
Merged
xuxinyi389 pushed a commit that referenced this pull request Jul 30, 2025
@xingmingyyj
Revert "Fix paddle.vision.ops.deform_conv2d API big Tensor (#74058)" (#…
2462ebd 
…74304)

This reverts commit 3067726.
@xingmingyyj xingmingyyj mentioned this pull request Jul 31, 2025
Merged
xingmingyyj added a commit to xingmingyyj/Paddle that referenced this pull request Aug 5, 2025
@xingmingyyj
Revert "Fix paddle.vision.ops.deform_conv2d API big Tensor (PaddlePad…
cf73a52 
…dle#74058)"

This reverts commit 3067726.
@xingmingyyj xingmingyyj mentioned this pull request Aug 5, 2025
Merged
xingmingyyj added a commit to xingmingyyj/Paddle that referenced this pull request Aug 6, 2025
@xingmingyyj
Revert "Fix paddle.vision.ops.deform_conv2d API big Tensor (PaddlePad…
9ff6253 
…dle#74058)"

This reverts commit 3067726.
phlrain pushed a commit that referenced this pull request Aug 7, 2025
@xingmingyyj @tianshuo78520a
Revert "Fix paddle.vision.ops.deform_conv2d API big Tensor (#74058)" (#…
7730c8b 
…74430)

* Revert "Fix paddle.vision.ops.deform_conv2d API big Tensor (#74058)"

This reverts commit 3067726.

* test=document_fix (#74337)

---------

Co-authored-by: tianshuo78520a <707759223@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@lshpku lshpku lshpku approved these changes

Assignees

No one assigned

Labels

skip-ci: coverage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xingmingyyj @codecov-commenter @wanghuancoder @lshpku @XieYunshen